chore: naming connect procedure #3157
Conversation
|
You can find the image built from this PR at Built from 146097d |
gabrielmer
force-pushed
the
chore-refactor-connections
branch
from
d48b947
to
a58fb41
Compare
| if not conf.relay: | ||
| return err("waku relay (--relay=true) should be set when configuring staticnodes") | ||
| try: | ||
| await connectToNodes(node, conf.staticnodes, "static") | ||
| except CatchableError: | ||
| return err("failed to connect to static nodes: " & getCurrentExceptionMsg()) | ||
|
|
||
| if dynamicBootstrapNodes.len > 0: | ||
| if not conf.relay: | ||
| return err( | ||
| "waku relay (--relay=true) should be set when configuring dynamicBootstrapNodes" | ||
| ) |
There was a problem hiding this comment.
We don't need these conditions that I added. When I added them I thought that connectToNodes, which called connectRelay, were only related to Relay protocol but the function name was a misnomer
gabrielmer
changed the title
gabrielmer
requested review from
Ivansete-status,
NagyZoltanPeter,
darshankabariya and
richard-ramos
and removed request for
Ivansete-status and
NagyZoltanPeter
|
Thanks for that! Nevertheless, I think is interesting having a more descriptive proc name because |
Makes sense! I updated it to Thank you! |
Description
Looking deeper at the code, I noticed that the
connectRelayprocedure uses thenim-libp2pconnectprocedure that connects to a node without setting a protocol.connectRelaywas a misnomer and it's more correct to call itconnectPeerChanges
connectRelaytoconnectPeerRelaybeing configured before callingconnectPeerconnectPeer, add peer if it's not found in the peer store instead of looking specifically for Waku Relay's codec